Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- Extension:Education Program was throwing fatal exceptions in production, like http://en.wikipedia.org/wiki/Education_Program:Rice_University/Poverty,_Gender,_and_Human_Development_Section_1_%28Spring_2013%29 caused by https://bugzilla.wikimedia.org/show_bug.cgi?id=46577
- Ori had this quite simple fix: https://gerrit.wikimedia.org/r/#/c/59113/ which Jeroen rejected in favor of a massive patch that fixes that problem but also changes five hundred other things: https://gerrit.wikimedia.org/r/#/c/56203/
- That's a 1000 line refactoring to fix a relatively simple bug.
- He also +2'd his own code.
- He merged all of his outstanding commits for that extension: https://gerrit.wikimedia.org/r/gitweb?p=mediawiki/extensions/EducationProgram.git;a=shortlog
- Reedy deployed the master and Ori reported getting a fatal on a different line.
- Someone had earlier complained that Jeroen had not synched his commits on WMF production after merging them. Krenair asked at this point whether Jeroen can actually do that.
- "if he could, he'd be getting it revoked right about now"
Advertisement
Add Comment
Please, Sign In to add comment
