PVS-StudioWarnings

PVS-Studio warning V668 for Chromium

Nov 13th, 2014
181
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. bool CrashService::Initialize(const std::wstring& command_line)
  2. {
  3.   ....
  4.     sender_ = new CrashReportSender(checkpoint_path.value());
  5.     if (!sender_) {
  6.       LOG(ERROR) << "could not create sender";
  7.       return false;
  8.     }
  9.   ....
  10. }
  11.  
  12. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V668 There is no sense in testing the 'sender_' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. crash_service.cc 221
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment