[20:10:10] <Azu> hey so I'm using worldedit-forge-mc1.10.2-6.1.4-SNAPSHOT-dist.jar and seeing a ton of issues with rotating logs/pillars in the clipboard, has this been noticed and possibly fixed since then?
[20:11:18] <Azu> and by "a ton" I think I just mean "it doesn't do it correctly"
[20:11:49] <Azu> copy some logs/pillars, rotate 90 degrees, paste, and they are not the correct variant
[20:12:07] <Azu> well, right block, wrong resulting direction
[20:30:47] <Azu> and I'm looking back at work I did like a year ago and seeing the same issue
[20:36:34] * Tenebrae ([email protected]) has joined #sk89q
[20:51:38] <@wizjany> uh
[20:51:42] <@wizjany> what blocks specifically
[20:59:15] <Azu> purpur pillars, some log that I can't remember if it was dark oak or spruce
[21:00:14] <Azu> I've since spotted this with participation from you in it http://dev.enginehub.org/youtrack/issue/WORLDEDIT-3490
[21:00:35] <Empire92> I think it's all logs, normal oak logs don't rotate as well
[21:01:25] <Empire92> The logs have axis information in the blocks.json which could be converted to direction in the BundledBlockData class
[21:04:04] <@wizjany> axis information isn't direction information
[21:04:24] <Empire92> wizjany, it can be converted without issue though
[21:04:36] <@wizjany> not without hardcoding names
[21:05:12] <Empire92> Yes it can, just check if states.containsKey("axis"), and convert that, you don't need to know specific names
[21:05:33] <@wizjany> "axis" <-- literally definition of harcoding
[21:06:22] <Empire92> Another solution is to do it in your registry dumper
[21:06:27] <@wizjany> still harcoding
[21:06:30] <@wizjany> do you
[21:06:32] <@wizjany> not understand
[21:06:35] <@wizjany> the definition here
[21:06:50] <@wizjany> if i have to manually write in the names of properties or their values to get a Vector from them
[21:06:51] <Empire92> Yeah, sure I understand that is's hardcoding. I didn't read properly before responding dude
[21:06:52] <@wizjany> it's hardcoding
[21:07:17] <@wizjany> which means
[21:07:26] <Empire92> You're arguing semantics, which is mostly unimportant. Are you willing for a fix that way or not?
[21:07:33] <@wizjany> yes
[21:07:38] <@wizjany> i mentioned that in my comments on that issue
[21:07:40] <@wizjany> that was just linked
[21:07:51] <@wizjany> "right, we'd somehow have to guess (or hardcode), based on the name of the properties, whether something like "axis" actually refers to rotation data, and then guess (or hardcode), based on the names of each value, what direction something like "up_x" refers to."
[21:08:00] <Empire92> I can do a pr
[21:13:06] * Nentify ([email protected]) Quit (Quit: Connection closed for inactivity)
[21:13:21] <@wizjany> i wonder if our old unit test still works at all
[21:13:26] <@wizjany> purpur pillars are new tho