PVS-StudioWarnings

PVS-Studio warning V501 for ACE

Nov 17th, 2014
200
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.81 KB | None | 0 0
  1. bool URL_Base::strip_scheme (ACE_CString& url_string)
  2. {
  3.   ...
  4.   ACE_CString::size_type pos = url_string.find (':');
  5.   if (pos > 0 &&
  6.       url_string[pos+1] == '/' &&
  7.       url_string[pos+1] == '/')
  8.   {
  9.     ...
  10.     // skip '<protocol>://'
  11.     url_string = url_string.substr (pos+3);
  12.   }
  13.   ...
  14. }
  15.  
  16. Most likely this is what should be written here: url_string[pos+1] == '/' && url_string[pos+2] == '/'.
  17.  
  18. This suspicious code was found in ACE project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V501 There are identical sub-expressions 'url_string[pos + 1] == '/'' to the left and to the right of the '&&' operator. INet urlbase.cpp 205
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment