PVS-StudioWarnings

PVS-Studio warning V668 for Chromium

Nov 12th, 2014
146
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.71 KB | None | 0 0
  1. TryChromeDialogView::Result TryChromeDialogView::ShowModal(
  2.   const ActiveModalDialogListener& listener)
  3. {
  4.   ....
  5.   popup_ = new views::Widget;
  6.   if (!popup_) {
  7.     NOTREACHED();
  8.     return DIALOG_ERROR;
  9.   }
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V668 There is no sense in testing the 'popup_' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. try_chrome_dialog_view.cc 90
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment