PVS-StudioWarnings

PVS-Studio warning V519 for Redis

Nov 13th, 2014
170
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.87 KB | None | 0 0
  1. int win32_pthread_join(pthread_t *thread, void **value_ptr)  {
  2.     int result;
  3.     HANDLE h = OpenThread(SYNCHRONIZE, FALSE, *thread);
  4.     REDIS_NOTUSED(value_ptr);
  5.  
  6.     switch (WaitForSingleObject(h, INFINITE)) {
  7.             case WAIT_OBJECT_0:
  8.                     result = 0;
  9.             case WAIT_ABANDONED:
  10.                     result = EINVAL;
  11.             default:
  12.                     result = GetLastError();
  13.     }
  14.  
  15.     CloseHandle(h);
  16.     return result;
  17. }
  18.  
  19. This suspicious code was found in Redis project by PVS-Studio static code analyzer.
  20. Warning message is:
  21. V519 The 'result' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 253, 255. win32fixes.c 255
  22.  
  23. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment