PVS-StudioWarnings

PVS-Studio warning V568 for FCEUX

Nov 19th, 2014
169
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.64 KB | None | 0 0
  1. BOOL updateResults(HWND hwndDlg, int rule)
  2. {
  3.   char buff[0x100];
  4.   ...
  5.   SendDlgItemMessage(hwndDlg, RULE_INPUT_1 + i, WM_GETTEXT,
  6.                      sizeof(buff - 1), (LPARAM) input_buff);
  7.   ...
  8. }
  9.  
  10. This is what should have been written here: sizeof(buff) - 1.
  11.  
  12. This suspicious code was found in FCEUX project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V568 It's odd that the argument of sizeof() operator is the 'buff - 1' expression. fceux monitor.cpp 117
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment