Guest User

Untitled

a guest
Sep 26th, 2016
89
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
  1. stronk7@~/git_moodle/integration ((v3.1.1) %)$ git bisect start
  2. stronk7@~/git_moodle/integration ((v3.1.1) %|BISECTING)$ git bisect bad
  3. stronk7@~/git_moodle/integration ((v3.1.1) %|BISECTING)$ git bisect good v3.1.0
  4. Bisecting: 162 revisions left to test after this (roughly 7 steps)
  5. [afee01ac2f59049add17bdfb3270b9eeae16f0da] Merge branch 'MDL-54920-m31' of https://github.com/sammarshallou/moodle into MOODLE_31_STABLE
  6. stronk7@~/git_moodle/integration ((afee01a...) %|BISECTING)$ vi oo.php
  7. stronk7@~/git_moodle/integration ((afee01a...) %|BISECTING)$ git bisect good
  8. Bisecting: 81 revisions left to test after this (roughly 6 steps)
  9. [c944c35cff4f4ce7cbecd142f3b888a655fecc1e] Merge branch 'MDL-54610_31' of https://github.com/snake/moodle into MOODLE_31_STABLE
  10. stronk7@~/git_moodle/integration ((c944c35...) %|BISECTING)$ git bisect bad
  11. Bisecting: 40 revisions left to test after this (roughly 5 steps)
  12. [ac081697dadc6bd60c11c7ab38fb711021e8e8c9] Merge branch 'MDL-52887-31' of git://github.com/marinaglancy/moodle into MOODLE_31_STABLE
  13. stronk7@~/git_moodle/integration ((ac08169...) %|BISECTING)$ git bisect bad
  14. Bisecting: 20 revisions left to test after this (roughly 4 steps)
  15. [e9019af21dc97f7f0e89515e87a54eedfa9eafcc] Merge branch 'MDL-54948-31-fix2' of https://github.com/lameze/moodle into MOODLE_31_STABLE
  16. stronk7@~/git_moodle/integration ((e9019af...) %|BISECTING)$ git bisect bad
  17. Bisecting: 11 revisions left to test after this (roughly 3 steps)
  18. [50804bc956f0fbb511c2c279608d8f6008d207d5] MDL-54778 form: Make it all js style (eslint) compliant
  19. stronk7@~/git_moodle/integration ((50804bc...) %|BISECTING)$ git bisect bad
  20. Bisecting: 3 revisions left to test after this (roughly 2 steps)
  21. [e2dee6f3cdd461e7123859b3f614c9d743b2e9fa] Merge branch 'MDL-54948-31' of git://github.com/lameze/moodle into MOODLE_31_STABLE
  22. stronk7@~/git_moodle/integration ((e2dee6f...) %|BISECTING)$ git bisect good
  23. Bisecting: 2 revisions left to test after this (roughly 1 step)
  24. [56fb03794cbc646676a2f61e11acb8b867ad9e51] MDL-54778 form: Fix lots of issues with form dependencies
  25. stronk7@~/git_moodle/integration ((56fb037...) %|BISECTING)$ git bisect bad
  26. 56fb03794cbc646676a2f61e11acb8b867ad9e51 is the first bad commit
  27. commit 56fb03794cbc646676a2f61e11acb8b867ad9e51
  28. Author: Andrew Nicols <andrew@nicols.co.uk>
  29. Date: Tue Jun 7 13:26:42 2016 +0800
  30.  
  31. MDL-54778 form: Fix lots of issues with form dependencies
  32.  
  33. The original issue here was that each loop of the named values did not
  34. check for prototypal properties. As a result, if there were input fields
  35. with names such as 'sort', 'valueOf', 'constructor', etc. these would
  36. return their prototypal functions instead of a falsy value, and be treated
  37. as though they are array - hence the 'Cannot push to Function' type error.
  38.  
  39. Following on from this I discovered that the data stores were being created
  40. as arrays, but used as objects. This can also cause issues with some form
  41. input names -- e.g. if they are numeric.
  42.  
  43. These two issues were resolved together by correctly storing them in
  44. objects, and checking that those objects had real properties
  45. (hasOwnProperty). This itself has to use the prototypal function to cater
  46. for the potential of a field name called 'hasOwnProperty'.
  47.  
  48. I also found that the instance value stores were being initialised in the
  49. prototype (and therefore shared), which meant that there were numerous
  50. issues if two forms were present on the same page, or one form replaced an
  51. existing one (e.g. forms initialised in JS).
  52.  
  53. In addition, it also became apparant that several values were being used
  54. outside of scope, or in the wrong scope. This caused further issues when
  55. creating multiple forms on a page.
  56.  
  57. :040000 040000 8927f77ee3d720c59e3599d2f532b119d887bf44 3339f2804bde9cbf15196d5e5e81dc577db5eabe M lib
RAW Paste Data