PVS-StudioWarnings

PVS-Studio warning V502 for ReactOS

Nov 17th, 2014
160
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.66 KB | None | 0 0
  1. VOID NTAPI
  2. AtapiDmaInit(....)
  3. {
  4.   ...
  5.   ULONG treg = 0x54 + (dev < 3) ? (dev << 1) : 7;
  6.   ...
  7. }
  8.  
  9. The "0x54 + (dev < 3)" condition is always true. This is the correct code: ULONG treg = 0x54 + ((dev < 3) ? (dev << 1) : 7).
  10.  
  11. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  12. Warning message is:
  13. V502 Perhaps the '?:' operator works in a different way than it was expected. The '?:' operator has a lower priority than the '+' operator. uniata id_dma.cpp 1610
  14.  
  15. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment