PVS-StudioWarnings

PVS-Studio warning V528 for TPP

Nov 20th, 2014
168
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. void SAXSpectraHandler::pushPeaks(....)
  2. {
  3.   ...
  4.   while(*pValue != '\0' && a < m_peaksCount) {
  5.     while(*pValue != '\0' && isspace(*pValue))
  6.       pValue++;
  7.     if(pValue == '\0')
  8.       break;
  9.     m_vfM.push_back((float)atof(pValue));
  10.     ...
  11. }
  12.  
  13. This is what should have been written here: if(*pValue == '\0')
  14.  
  15.  
  16. This suspicious code was found in TPP project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V528 It is odd that pointer to 'char' type is compared with the '\0' value. Probably meant: *pValue == '\0'. xtandem saxhandler.cpp 323
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment