PVS-StudioWarnings

PVS-Studio warning V547 for samba

Nov 10th, 2014
159
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.58 KB | None | 0 0
  1. static size_t convert_string_internal(....)
  2. {
  3.   ....
  4.     if (((from == CH_UTF16LE)||(from == CH_UTF16BE)) &&
  5.         ((to != CH_UTF16LE)||(to != CH_UTF16BE))) {
  6.   ....
  7. }
  8.  
  9. This suspicious code was found in samba project by PVS-Studio static code analyzer.
  10. Warning message is:
  11. V547 Expression '(to != CH_UTF16LE) || (to != CH_UTF16BE)' is always true. Probably the '&&' operator should be used here. charcnv.c 188
  12.  
  13. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment