Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- so yeah I tested pressing U on a skull
- and it works kinda
- it cycles (very slowly, I'm guessing there's a bunch of dupe recipes) and the stack size of the skull never changes
- so you get the wrong recipe
- HenryLoenwind - Last Wednesday at 5:24 PM
- as I expected. the list sizes between skulls and the rest now differ
- tterrag - Last Wednesday at 5:24 PM
- it shouldn't, I've changed nothing when the focus is an input
- ItemStack focusStack = focus == null || focus.getMode() != Mode.OUTPUT ? null : (ItemStack) focus.getValue();
- HenryLoenwind - Last Wednesday at 5:24 PM
- I'd just reset ingredients to the full set in this case.
- you didn't, but JEI reduces one list but not the others
- our variant cycling only works if all 4 lists have exactly the same size
- tterrag - Last Wednesday at 5:25 PM
- I don't understand...this logic should be the same
- did this bug exist before?
- HenryLoenwind - Last Wednesday at 5:25 PM
- yes
- tterrag - Last Wednesday at 5:25 PM
- and "I'd just reset ingredients to the full set" -- how?
- HenryLoenwind - Last Wednesday at 5:25 PM
- getIngredients()
- tterrag - Last Wednesday at 5:26 PM
- if (focusStack != null) {
- recipeWrapper.getIngredients(ingredients, EnchantmentHelper.getEnchantments(focusStack).get(recipeWrapper.rec.getEnchantment()));
- } else {
- recipeWrapper.getIngredients(ingredients);
- }
- HenryLoenwind - Last Wednesday at 5:26 PM
- instead of using the filtered parameter
- tterrag - Last Wednesday at 5:26 PM
- changes nothing :/
- again the filtering only runs when the focus is an output
- HenryLoenwind - Last Wednesday at 5:26 PM
- yes, you need to reset when there's an input focus
- tterrag - Last Wednesday at 5:27 PM
- that's what is happening there
- here is the full logic:
- IFocus<?> focus = recipeLayout.getFocus();
- ItemStack focusStack = focus == null || focus.getMode() != Mode.OUTPUT ? null : (ItemStack) focus.getValue();
- if (focusStack != null) {
- recipeWrapper.getIngredients(ingredients, EnchantmentHelper.getEnchantments(focusStack).get(recipeWrapper.rec.getEnchantment()));
- } else {
- recipeWrapper.getIngredients(ingredients);
- }
- guiItemStacks.set(ingredients);
- HenryLoenwind - Last Wednesday at 5:28 PM
- we rely on the fact that all 4 lists have the same size, so they cycle in sync. the moemnt one of them is smaller (because it was decimated by an input focus), the cycling mixes up stuff
- tterrag - Last Wednesday at 5:28 PM
- I get that but idk how to fix it
- I think JEI is messing with it further down the line...the ingredients should be unmodified from the recipewrapper at this point
- HenryLoenwind - Last Wednesday at 5:28 PM
- yeah, this looks like it should work(edited)
- tterrag - Last Wednesday at 5:29 PM
- same result though
- it doesn't
- HenryLoenwind - Last Wednesday at 5:29 PM
- ping mezz?
- tterrag - Last Wednesday at 5:30 PM
- @mezz halp
Advertisement
Add Comment
Please, Sign In to add comment