Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- HRESULT
- SHEOW_LoadOpenWithItems(SHEOWImpl *This, IDataObject *pdtobj)
- {
- ...
- if (_ILIsDesktop(pidl) || _ILIsMyDocuments(pidl) ||
- _ILIsControlPanel(pidl) || _ILIsNetHood(pidl) ||
- _ILIsBitBucket(pidl) || _ILIsDrive(pidl) ||
- _ILIsCPanelStruct(pidl) || _ILIsFolder(pidl) ||
- _ILIsControlPanel(pidl))
- {
- TRACE("pidl is a folder\n");
- SHFree((void*)pidl);
- return E_FAIL;
- }
- ...
- }
- You have to strain your eyes, but if you look closely, you will notice that _ILIsControlPanel(pidl) is repeated twice.
- This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
- Warning message is:
- V501 There are identical sub-expressions '_ILIsControlPanel (pidl)' to the left and to the right of the '||' operator. shell32 she_ocmenu.c 1222
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment