PVS-StudioWarnings

PVS-Studio warning V501 for QT

Nov 13th, 2014
174
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 1.45 KB | None | 0 0
  1. bool qt_resolve_glsl_extensions(QGLContext *ctx)
  2. {
  3.   ...
  4.   return glCreateShader &&
  5.     glShaderSource &&
  6.     glCompileShader &&
  7.     glDeleteProgram &&      <<<---
  8.     glCreateProgram &&
  9.     glAttachShader &&
  10.     glDetachShader &&
  11.     glLinkProgram &&
  12.     glUseProgram &&
  13.     glDeleteProgram &&      <<<---
  14.     glGetShaderInfoLog &&
  15.     glGetShaderiv &&
  16.     glGetShaderSource &&
  17.     glGetProgramiv &&
  18.     glGetProgramInfoLog &&
  19.     glGetUniformLocation &&
  20.     glUniform1fv &&
  21.     glUniform2fv &&
  22.     glUniform3fv &&
  23.     glUniform4fv &&
  24.     glUniform1i &&
  25.     glUniform1iv &&
  26.     glUniformMatrix2fv &&
  27.     glUniformMatrix3fv &&
  28.     glUniformMatrix4fv &&
  29.     glBindAttribLocation &&
  30.     glGetAttribLocation &&
  31.     glVertexAttrib1fv &&
  32.     glVertexAttrib2fv &&
  33.     glVertexAttrib3fv &&
  34.     glVertexAttrib4fv &&
  35.     glVertexAttribPointer &&
  36.     glDisableVertexAttribArray &&
  37.     glEnableVertexAttribArray;
  38.   ...
  39. }
  40.  
  41. There's no error. It's just an unnecessary line. It is still useful to find and fix such code fragments: your code will become a bit shorter.
  42.  
  43. This suspicious code was found in QT project by PVS-Studio static code analyzer.
  44. Warning message is:
  45. V501 There are identical sub-expressions to the left and to the right of the '&&' operator. QtOpenGL qglextensions.cpp 367
  46.  
  47. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment