PVS-StudioWarnings

PVS-Studio warning V668 for Chromium

Nov 19th, 2014
156
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.89 KB | None | 0 0
  1. WebContents*
  2. PrintPreviewDialogController::CreatePrintPreviewDialog(
  3.   WebContents* initiator)
  4. {
  5.   ....
  6.   Browser* current_browser = new Browser(
  7.       Browser::CreateParams(Browser::TYPE_POPUP, profile,
  8.                             chrome::GetActiveDesktop()));
  9.   if (!current_browser) {
  10.     NOTREACHED() << "Failed to create popup browser window";
  11.     return NULL;
  12.   }
  13.   ....
  14. }
  15.  
  16. This suspicious code was found in Chromium project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V668 There is no sense in testing the 'current_browser' pointer against null, as the memory was allocated using the 'new' operator. The exception will be generated in the case of memory allocation error. print_preview_dialog_controller.cc 403
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment