PVS-StudioWarnings

PVS-Studio warning V610 for webrtc

Nov 11th, 2014
141
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.67 KB | None | 0 0
  1. int32_t
  2. RTCPSender::BuildREMB(uint8_t* rtcpbuffer, uint32_t& pos)
  3. {
  4.   ....
  5.   for(uint32_t i=0; i<64; i++)
  6.   {
  7.     if(_rembBitrate <= ((uint32_t)262143 << i))
  8.     {
  9.       brExp = i;
  10.       break;
  11.     }
  12.   }
  13.   ....
  14. }
  15.  
  16. This suspicious code was found in webrtc project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V610 Undefined behavior. Check the shift operator '<<. The right operand ('i' = [0..63]) is greater than or equal to the length in bits of the promoted left operand. rtcp_sender.cc 1105
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment