PVS-StudioWarnings

PVS-Studio warning V597 for PostgreSQL

Nov 19th, 2014
155
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. char *
  2. px_crypt_md5(const char *pw, const char *salt,
  3.              char *passwd, unsigned dstlen)
  4. {
  5.   ....
  6.   unsigned char final[MD5_SIZE];
  7.   ....
  8.   /* Don't leave anything around in vm they could use. */
  9.   memset(final, 0, sizeof final);
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in PostgreSQL project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V597 The compiler could delete the 'memset' function call, which is used to flush 'final' buffer. The RtlSecureZeroMemory() function should be used to erase the private data. pgcrypto crypt-md5.c 157
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment