Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- void
- Mapdesc::identify( REAL dest[MAXCOORDS][MAXCOORDS] )
- {
- memset( dest, 0, sizeof( dest ) );
- for( int i=0; i != hcoords; i++ )
- dest[i][i] = 1.0;
- }
- The 'dest' object is simply a pointer. Value [MAXCOORDS][MAXCOORDS] in the square brackets indicates to the programmer that he is working with an array of MAXCOORDS x MAXCOORDS items.
- But it is not an array of items which is passed into the function - it is only the pointer.
- So, the sizeof(dest) expression will return value 4 or 8 (the size of the pointer in a 32-bit/64-bit system).
- This is what should have been written here: Mapdesc::identify( REAL (&dest)[MAXCOORDS][MAXCOORDS] )
- This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
- Warning message is:
- V511 The sizeof() operator returns size of the pointer, and not of the array, in 'sizeof (dest)' expression. glu32 mapdesc.cc 95
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment