Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- typedef char PID[pid_len+1];
- typedef char PPS[pps_len+1];
- static void generate(PID pid, PPS pps)
- {
- memset(pid,0,sizeof(pid));
- memset(pps,0,sizeof(pps));
- ...
- }
- The 'pid/pps' object is simply a pointer. Value pid_len+1 / pps_len+1 in the square brackets indicates to the programmer that he is working with an array of N items.
- But it is not an array of items which is passed into the function - it is only the pointer.
- So, the sizeof(pid) / sizeof(pps) expression will return value 4 or 8 (the size of the pointer in a 32-bit/64-bit system).
- This suspicious code was found in amtsdk project by PVS-Studio static code analyzer.
- Warning message is:
- V511 The sizeof() operator returns size of the pointer, and not of the array, in 'sizeof (pid)' expression. PskGenerator pskgenerator.cpp 126
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment