PVS-StudioWarnings

PVS-Studio warning V524 for TortoiseSVN

Nov 19th, 2014
170
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.79 KB | None | 0 0
  1. BOOL GetImageHlpVersion(DWORD &dwMS, DWORD &dwLS)
  2. {
  3.   return(GetInMemoryFileVersion(("DBGHELP.DLL"),
  4.                                 dwMS,
  5.                                 dwLS)) ;
  6. }
  7.  
  8. BOOL GetDbgHelpVersion(DWORD &dwMS, DWORD &dwLS)
  9. {
  10.   return(GetInMemoryFileVersion(("DBGHELP.DLL"),
  11.                                 dwMS,
  12.                                 dwLS)) ;
  13. }
  14.  
  15. This suspicious code was found in TortoiseSVN project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V524 It is odd that the 'GetDbgHelpVersion' function is fully equivalent to the 'GetImageHlpVersion' function (SymbolEngine.h, line 98). symbolengine.h 105
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment