PVS-StudioWarnings

PVS-Studio warning V636 for libevent

Nov 20th, 2014
187
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.74 KB | None | 0 0
  1. static int cfg_grouplimit = 0;
  2. static int cfg_n_connections = 30;
  3.  
  4. static int
  5. test_ratelimiting(void)
  6. {
  7.   double expected_avg_persec = -1.0;
  8.   ....
  9.   expected_avg_persec = cfg_grouplimit / cfg_n_connections;
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in libevent project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V636 The 'cfg_grouplimit / cfg_n_connections' expression was implicitly casted from 'int' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;. test-ratelim.c 242
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment