PVS-StudioWarnings

PVS-Studio warning V547 for ICU

Nov 12th, 2014
180
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.61 KB | None | 0 0
  1. U_CDECL_BEGIN static const char* U_CALLCONV
  2. _processVariableTop(....)
  3. {
  4.   ...
  5.   if(i == locElementCapacity &&
  6.      (*string != 0 || *string != '_')) {
  7.     *status = U_BUFFER_OVERFLOW_ERROR;
  8.   }
  9.   ...
  10. }
  11.  
  12. This suspicious code was found in ICU project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V547 Expression '* string != 0 || * string != '_'' is always true. Probably the '&&' operator should be used here. icui18n ucol_sit.cpp 242
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment