PVS-StudioWarnings

PVS-Studio warning V547 for WinMerge

Nov 19th, 2014
167
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.76 KB | None | 0 0
  1. void CMergeDoc::Computelinediff(....)
  2. {
  3.   ....
  4.   vector<wdiff*>::size_type i;
  5.   ....
  6.   for (i=worddiffs.size() - 1; i>=0; --i)
  7.   {
  8.     const wdiff * diff = worddiffs[i];
  9.     if (end1 == -1 && diff->end[0] != -1)
  10.       end1 = diff->end[0];
  11.     if (end2 == -1 && diff->end[1] != -1)
  12.       end2 = diff->end[1];
  13.     if (end1 != -1 && end2 != -1)
  14.       break; // found both
  15.   }
  16.   ....
  17. }
  18.  
  19. This suspicious code was found in WinMerge project by PVS-Studio static code analyzer.
  20. Warning message is:
  21. V547 Expression 'i >= 0' is always true. Unsigned type value is always >= 0. mergedoclinediffs.cpp 282
  22.  
  23. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment