Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- bool DAGCombiner::SimplifySelectOps(....) {
- ...
- LoadSDNode *LLD = cast<LoadSDNode>(LHS);
- LoadSDNode *RLD = cast<LoadSDNode>(RHS);
- ...
- if ((LLD->hasAnyUseOfValue(1) &&
- (LLD->isPredecessorOf(CondLHS) ||
- LLD->isPredecessorOf(CondRHS))) ||
- (LLD->hasAnyUseOfValue(1) &&
- (LLD->isPredecessorOf(CondLHS) ||
- LLD->isPredecessorOf(CondRHS))))
- return false;
- ...
- }
- A Copy-Paste error. The programmer seems to have forgotten to replace LLD with RLD in three places.
- This suspicious code was found in Clang project by PVS-Studio static code analyzer.
- Warning message is:
- V501 There are identical sub-expressions to the left and to the right of the '||' operator. LLVMSelectionDAG dagcombiner.cpp 7340
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment