<cheimes> bhavik: edewata has approved the PR and I just landed the banner fix.
<bhavik> cheimes: cool thanks ...I will run my test again with the nightly
<edewata> cheimes: bhavik: thanks guys!
<bhavik> edewata: by when can I see this change in nightly ?
* aadhikar has quit (Quit: Leaving)
<edewata> bhavik: according to the timestamp it's built everyday at 2am, probably EST
<bhavik> edewata: ok
<edewata> bhavik: but if you need it sooner I think I can create a manual build quickly
<bhavik> edewata: sure, if possible I would like to test it out.
<edewata> bhavik: ok, I'll ping you when it's ready
<bhavik> edewata: thanks
<edewata> bhavik: it's building https://copr.fedorainfracloud.org/coprs/g/pki/10.6-nightly/build/757300/
<bhavik> edewata: thanks will try it out as soon as the build is complete
* aakkiang (~aakkiang@dhcp129-20.rdu.redhat.com) has joined #cs
* aakkiang has quit (Read error: Connection reset by peer)
* aakkiang_ (~aakkiang@dhcp129-20.rdu.redhat.com) has joined #cs
* aakkiang_ is now known as aakkiang
* Amyra|out is now known as Amyra
* gkapoor (~gkapoor@ovpn-117-10.sin2.redhat.com) has joined #cs
* xdong has quit (Ping timeout: 612 seconds)
* gparente_afk is now known as gparente
* aborah_ (~aborah@dhcp223-44.pnq.redhat.com) has joined #cs
* mhernon (~textual@ovpn-123-93.rdu2.redhat.com) has joined #cs
* dpal (~dpal@ovpn-122-50.rdu2.redhat.com) has joined #cs
* aborah has quit (Ping timeout: 612 seconds)
* aborah_ has quit (Quit: Leaving)
* tmihinto_mtg is now known as tmihinto
* prasadk (~pkulkarn@10.76.0.150) has joined #cs
* KeslerS (~kstrickl@ovpn-123-87.rdu2.redhat.com) has joined #cs
* jaosorior_ is now known as jaosorior
* mreznik|lunch is now known as mreznik
* xdong (~xdong@ovpn-123-95.rdu2.redhat.com) has joined #cs
* tmihinto is now known as tmihinto_lunch
* praspa|afk is now known as praspa
* jreznik_ (~jreznik@10.34.245.88) has joined #cs
* dberry (~dberry@ovpn-124-28.rdu2.redhat.com) has joined #cs
* jreznik has quit (Ping timeout: 612 seconds)
<bhavik> edewata: we got 4 more tests passing after the fix, now the negative test where we set binary text for banner is failing with 'utf-8' codec can't decode byte 0xf3 in position 1: invalid continuation byte
<bhavik> edewata: https://gitlab.com/bhavikbhavsar/pki/-/jobs/69731810
<edewata> cheimes: ^^
* rpattath (~rpattath@ovpn-124-213.rdu2.redhat.com) has joined #cs
<cheimes> bhavik: 0xf3 is not valid UTF-8 encoded payload
* drieden has quit (Ping timeout: 606 seconds)
<bhavik> cheimes: agree it's a negative side test were I add binary text and check for response
<cheimes> \xf3 is ó in latin-1
<cheimes> it's not text
<bhavik> cheimes: previously it used to show ERROR: Banner contains invalid character(s)
* prasadk is now known as prasadk|afk
<cheimes> bhavik: ok, then the code needs to be changed and handle the issue earlier
<edewata> bhavik: is there a stack trace?
<bhavik> edewata: https://pastebin.com/3mRgbZLu
* tmihinto_lunch is now known as tmihinto
<edewata> cheimes: do you want to fix this, or should I?
<cheimes> edewata: The fix should be easy, wrap the io.open() call in a try/except UnicodeDecodeError.
<cheimes> I'm in a meeting
<edewata> cheimes: yeah, there are 2 places though
* rpattath has quit (Ping timeout: 612 seconds)
<edewata> cheimes: when you have time: https://review.gerrithub.io/#/c/dogtagpki/pki/+/412043/
* rrajashe (rrajashe@10.19.40.117) has joined #cs
* rrajashe has quit (Remote host closed the connection)
* akahat has quit (Quit: Leaving)
* Amit-Kumar has quit (Remote closed the connection)
<cheimes> edewata: I think you can remove the try/except around the XML code now.
<edewata> cheimes: are you sure? what if the banner contains badly formatted xml tags?
* drieden (~drieden@ovpn-116-239.phx2.redhat.com) has joined #cs
<edewata> cheimes: or should we just remove the whole validation with xml?
<cheimes> edewata: aah, you allow random characters?
<cheimes> shouldn't you quote the XML?
<edewata> cheimes: banner is admin configurable text file
<edewata> cheimes: they can put anything
<edewata> cheimes: we're just making sure it can be sent over REST API later
<cheimes> edewata: then you are right
<edewata> cheimes: the XML validation was done to detect invalid chars
<cheimes> edewata: I thought it's plain-text only. But if you accept any XML, then you have to keep it.
<cheimes> banner text will be UTF-8 now.
<edewata> cheimes: then it's probably not needed anymore, the REST client will display the banner text as is, it's not going to be parsed as xml.
* prasadk|afk is now known as prasadk
* rpattath (~rpattath@ovpn-124-3.rdu2.redhat.com) has joined #cs
* Amyra is now known as Amyra|IDMCall
<edewata> cheimes: oh btw, we do want to show the position of the invalid char if possible
<edewata> cheimes: so we may want to show the exception message
<cheimes> +1