Guest User

Untitled

a guest
Jun 21st, 2018
293
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 3.72 KB | None | 0 0
  1. diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
  2. index bb8d995..124f6f5 100644
  3. --- a/WebCore/ChangeLog
  4. +++ b/WebCore/ChangeLog
  5. @@ -1,3 +1,15 @@
  6. +2010-11-10 Andreas Kling <kling@webkit.org>
  7. +
  8. + Reviewed by Kenneth Rohde Christiansen.
  9. +
  10. + In paintEntireContents mode (used in combination with tiling) we
  11. + cannot clip to the actual visibleContentRect as the clipped regions
  12. + will not be updated again on scroll. If paintsEntireContents is
  13. + enabled, return the actual content rect.
  14. +
  15. + * page/FrameView.cpp:
  16. + (WebCore::FrameView::windowClipRect):
  17. +
  18. 2010-11-11 Dan Bernstein <mitz@apple.com>
  19.  
  20. Reverted r71975:71976. That change was wrong, and the tests caught it.
  21. diff --git a/WebCore/page/FrameView.cpp b/WebCore/page/FrameView.cpp
  22. index f4b9b9f..fe0be6a 100644
  23. --- a/WebCore/page/FrameView.cpp
  24. +++ b/WebCore/page/FrameView.cpp
  25. @@ -1842,6 +1842,9 @@ IntRect FrameView::windowClipRect(bool clipToContents) const
  26. {
  27. ASSERT(m_frame->view() == this);
  28.  
  29. + if (paintsEntireContents())
  30. + return IntRect(IntPoint(0, 0), contentsSize());
  31. +
  32. // Set our clip rect to be our contents.
  33. IntRect clipRect = contentsToWindow(visibleContentRect(!clipToContents));
  34. if (!m_frame || !m_frame->document() || !m_frame->document()->ownerElement())
  35. diff --git a/WebKit/qt/Api/qgraphicswebview.cpp b/WebKit/qt/Api/qgraphicswebview.cpp
  36. index f026827..6cc2aa0 100644
  37. --- a/WebKit/qt/Api/qgraphicswebview.cpp
  38. +++ b/WebKit/qt/Api/qgraphicswebview.cpp
  39. @@ -141,6 +141,7 @@ void QGraphicsWebViewPrivate::updateResizesToContentsForPage()
  40. q, SLOT(_q_contentsSizeChanged(const QSize&)));
  41. }
  42. page->d->page->settings()->setShouldDelegateScrolling(resizesToContents);
  43. + page->d->page->mainFrame()->view()->setPaintsEntireContents(resizesToContents);
  44. }
  45.  
  46. void QGraphicsWebViewPrivate::_q_contentsSizeChanged(const QSize& size)
  47. diff --git a/WebKit/qt/ChangeLog b/WebKit/qt/ChangeLog
  48. index cf6a32f..83c1fab 100644
  49. --- a/WebKit/qt/ChangeLog
  50. +++ b/WebKit/qt/ChangeLog
  51. @@ -1,3 +1,16 @@
  52. +2010-11-10 Andreas Kling <kling@webkit.org>
  53. +
  54. + Reviewed by Kenneth Rohde Christiansen.
  55. +
  56. + Use paintEntireContents in combination with tiling, allowing to
  57. + actually set visibleContentRect to something different from
  58. + the actual contents size.
  59. +
  60. + * Api/qgraphicswebview.cpp:
  61. + (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
  62. + * WebCoreSupport/FrameLoaderClientQt.cpp:
  63. + (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
  64. +
  65. 2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>
  66.  
  67. Unreviewed, rolling out r71733.
  68. diff --git a/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp b/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
  69. index 1b57138..1ffcfb7 100644
  70. --- a/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
  71. +++ b/WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp
  72. @@ -274,12 +274,18 @@ void FrameLoaderClientQt::transitionToCommittedForNewPage()
  73. bool hLock = hScrollbar != ScrollbarAuto;
  74. bool vLock = vScrollbar != ScrollbarAuto;
  75.  
  76. + bool paintsEntireContents = m_frame->view() && m_frame->view()->paintsEntireContents();
  77. +
  78. m_frame->createView(m_webFrame->page()->viewportSize(),
  79. backgroundColor, !backgroundColor.alpha(),
  80. preferredLayoutSize.isValid() ? IntSize(preferredLayoutSize) : IntSize(),
  81. preferredLayoutSize.isValid(),
  82. hScrollbar, hLock,
  83. vScrollbar, vLock);
  84. +
  85. + bool isMainFrame = m_frame == m_frame->page()->mainFrame();
  86. + if (isMainFrame)
  87. + m_frame->view()->setPaintsEntireContents(paintsEntireContents);
  88. }
  89.  
  90. void FrameLoaderClientQt::dispatchDidBecomeFrameset(bool)
Add Comment
Please, Sign In to add comment