PVS-StudioWarnings

PVS-Studio warning V568 for ReactOS

Nov 20th, 2014
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.75 KB | None | 0 0
  1. static DWORD CALLBACK
  2. RegistrationProc(LPVOID Parameter)
  3. {
  4.   ...
  5.   if (0 == LoadStringW(hDllInstance, IDS_UNKNOWN_ERROR,
  6.           UnknownError,
  7.           sizeof(UnknownError) / sizeof(UnknownError[0] -
  8.           20)))
  9.   ...
  10. }
  11.  
  12. A parenthesis seems to be put in a wrong place. This code should look like this: sizeof(UnknownError) / sizeof(UnknownError[0]).
  13.  
  14. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V568 It's odd that the argument of sizeof() operator is the 'UnknownError [0] - 20' expression. syssetup wizard.c 1696
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment