PVS-StudioWarnings

PVS-Studio warning V646 for KDE4

Nov 19th, 2014
155
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.72 KB | None | 0 0
  1. *bool KArchive::close()
  2. {
  3.   ....
  4.   // if d->saveFile is not null then it is equal to d->dev.
  5.   if ( d->saveFile ) {
  6.     closeSucceeded = d->saveFile->finalize();
  7.     delete d->saveFile;
  8.     d->saveFile = 0;
  9.   } if ( d->deviceOwned ) {                                 //<==
  10.     delete d->dev; // we created it ourselves in open()
  11.   }
  12.   ....
  13. }
  14.  
  15. This suspicious code was found in KDE4 project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V646 Consider inspecting the application's logic. It's possible that 'else' keyword is missing. karchive.cpp 187
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment