Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- static BOOL CALLBACK MemWatchCallB(
- HWND hwndDlg, UINT uMsg, WPARAM wParam, LPARAM lParam)
- {
- ...
- EnableMenuItem(memwmenu,MEMW_FILE_SAVE,
- MF_BYCOMMAND | fileChanged ? MF_ENABLED:MF_GRAYED);
- ...
- }
- This is what it turns out to be: (MF_BYCOMMAND | fileChanged) ? MF_ENABLED:MF_GRAYED, while it should actually be: MF_BYCOMMAND | (fileChanged ? MF_ENABLED:MF_GRAYED). The code works due to sheer luck, as #define MF_BYCOMMAND 0x00000000L.
- This suspicious code was found in FCEUX project by PVS-Studio static code analyzer.
- Warning message is:
- V564 The '|' operator is applied to bool type value. You've probably forgotten to include parentheses or intended to use the '||' operator. fceux memwatch.cpp 711
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment