Weeding Out Old Bugs

<The_E> 1114
<Valathil> i've never seen shittier thruster graphics
*** MjnRoaming has quit IRC: Ping timeout: 202 seconds
*** MjnPhone has joined #scp
*** MjnPhone has quit IRC: Client Quit
<The_E> Time to weed out some old bugs
<Valathil> you sure this bug is still active
<The_E> Nope
<Valathil> seems man thrusters are rendered before the ship
<The_E> But then, I don't have data shitty enough to repro
<Valathil> hehe man thrusters
*** MjnMobile has quit IRC: Ping timeout: 190 seconds
<Valathil> i mean they are batched
<Valathil> so the would have gone after before
<Valathil> but engine glows are now batched as well since the thruster distortion
<Valathil> so ill take a guess and say its fixed
<The_E> I would say so as well
<The_E> There are quite a few zombie issues lurking amongst the "assigned" set
<The_E> Looking at 1811, and I'm just going "wat? This is holding up an mvp release?"
<Valathil> da fuw
*** FUBAR-BDHR_ has quit IRC: Ping timeout: 202 seconds
<Valathil> this isnt even a bug its coded that way that if there are lot of hits on screen that the old ones are cut off
<The_E> Indeed
<Valathil> id say close with extreme prejudice
<The_E> I will concede that that's behaviour that should be documented and shit, but I don't exactly see the need to "fix" it
<The_E> If you want a 50-second shield hit effect, you're doing it wrong anyway
<Valathil> looks fucking awesome in slow motion
<Valathil> you can see every energy ripple
<Valathil> plasma discharges
<The_E> real-time shield mesh distortion action
<Valathil> stop you making me wet
<The_E> Tesselate that mesh to hell and distort the crap out of it
<Valathil> i came
<The_E> ogod
<The_E> 1616
<The_E> it's a goddamn change-ship-type bug again
<Valathil> aahm shouldnt swapping the ship class invalidate all texture replacements anyway?
<The_E> Yes, _except_ in the special case of the original and target ship sharing the model apparently
<Valathil> cause that happens so fucking often?
<Valathil> there is a sexp to do tex replacement isnt there?
<The_E> If I can't deal with it in half an hour, I'm closing it as No Change Required Go Die In A Fire
<Valathil> FOAD
*** Swifty has joined #scp
<The_E> Gods
<The_E> Whoever came up with the braindead idea of storing the replacement texture info behind an int*
<The_E> Memory leaks and potential overruns are _such_ nice things to have
<Swifty> hey I just live here.
<Swifty> but I agree it's kinda derpy
<The_E> Of all the things Goober criticizes, he thinks that code is rock-solid?
<Valathil> http://i3.kym-cdn.com/photos/images/original/000/361/483/bdd.jpg
*** Zacam-Work has joined #scp
<MjnMixael> ok, i'm home
<MjnMixael> lemme eat, then I shall don my mantis boots
<Valathil> i read boobs
<MjnMixael> till then 1153 just needs confirmation and probably closure
<The_E> http://pastebin.com/K6JY4ZmY
<Valathil> cant you just reattach the pointer
<Valathil> why must be copied?
<The_E> True, I could just do that
<Valathil> thats the beauty of pointers
<The_E> Okay, moving on
<The_E> In keeping with the theme, look at 1775
<The_E> Sure, why not use code from a codebase very few of us have seen and that is already 3000+ revisions behind trunk
<Valathil> Closed:  "Too old to fix"
<MjnMixael> k, ima browse for bugs
<MjnMixael> 2188
<Swifty> closing mantis 14 was one of the satisfying moments of my career
<Swifty> most*
<Valathil> soft particles?
<Zacam-Work> Don't worry about 1775
*** m|m has quit IRC: Quit: m|m
<The_E> What
<The_E> What the actual fuck
<The_E> 2733
<The_E> Assigned to: Kazan
<The_E> When did he come back to code for FSO
<Zacam-Work> He didn't.
<Zacam-Work> I don't know who that was intended for, but it's not him.
<Valathil> http://i0.kym-cdn.com/photos/images/original/000/195/379/1320452774001.png
<Zacam-Work> Wait, it WAS explicitly intended for him? ...
<Zacam-Work> Right, chartering a flight to DC.
<MjnMixael> were there decisions on 1114, 1616, or 1153?
<MjnMixael> derp 1616 was just done
<The_E> AAAAAAARGH
<The_E> Gods
<The_E> And now I discover that Kazan was apparently unable to follow established convention when documenting his sexps
<The_E> IS THAT SO FUCKING HARD
<Zacam-Work> HAHAHAHAHAHAHAHHAHAHAHA
<Valathil> i think e is going super sayian any second now
<Zacam-Work> Kazan, follow -ANYTHING- that somebody else did? Fuck no. Cause he always knew bestest and that was that.
<MjnMixael> Zacam, can you ad 1841 on your list to check later?
<Zacam-Work> If anything, dealing with Keldor is EASY compared to Kazan.
<Zacam-Work> Well, I reported it, it's assigned to me, and I'm monitoring it. But yeah, I need to retest that bastard.
<MjnMixael> aha, here's a possible one for you Valathil. 2693
<MjnMixael> lemme confirm it first, though
<Valathil> that be nice
<The_E> Just look at the help text for add-nav-waypoint
<The_E> Fuck it, I need some Borderlands now
*** HerraTohtori has joined #scp
<MjnMixael> ok, Valathil, confirmed and I've setup a new modpack that doesn't throw all kinds of debug warnings that are unrelated
<Valathil> yay
<Valathil> thanks ill look into it
<MjnMixael> https://dl.dropbox.com/u/6681376/Collision%20Test.7z
<MjnMixael> should I try to put something together for 1114, or is that just going to be closed?
<Valathil> na that is 80% already fixed
<MjnMixael> The_E: close 1897?
<Valathil> 90% when you think about how we dont do alpha blending on billboards anymore i think its all additive
<Valathil> and that means the order of rendering doesnt matter
<MjnMixael> right
<MjnMixael> close eeet
<Valathil> DOOOOONE
<Valathil> so what im i looking for in collisiontest
<MjnMixael> he set $no collisions on the Fenris and so it should behave as such, however it does collide with the Ganymede. You can fly through it, which I think is expected, but not through it's subobjects
<Zacam-Work> On a purely unrelated note, the universe has annoyed me with assuming that "crap" is a decent substitute just because it has quantity.
<Zacam-Work> So, my headphones finally gave up the ghost. 9 hours of on-line searching later, I finally find a decent replacement pair. I get them, and then the audio jack on the media player fails. I have yet to find a decent replacement that meets my requirements.
<Valathil> wasnt there a cmdline for using the old collision system?
<Valathil> i wanted to test if this comes from go_even_faster
<Zacam-Work> ...yes?
*** Eli2_ has joined #scp
<MjnMixael> yeah, it's under 'Troubleshoot'
<Valathil> wrong exe selected
<Valathil> i suck cocks
<Zacam-Work> '-old_collision'
*** Eli2 has quit IRC: Ping timeout: 190 seconds
<Valathil> funny thing is you collide ship to ship with the antenna but shots go thru
<Swifty> valathil, are you kidding me? We definitely do alpha blending on billboards
<Swifty> it's not additive, it's premultiplied
<Swifty> that's why it's order independent
<Zacam-Work> (or should be)
<Valathil> yeah its complicated with the words
<Zacam-Work> but if the content doesn't have the -right- shade of black or whatever...
<Valathil> additive blending is also alpha blending
<Valathil> src*srca + dest*(1-srca) what id call alpha blending is order dependent but src*srca +dest what id call additive blending isnt
<Valathil> but i know additive also has alpha
<Valathil> aaaaaaaaaaaaaaahm
<Valathil> i cant find
$no_collisions anywhere
<Valathil> ah TAB
<Swifty> both are alpha blending. blend(source, dest)  =  (source.rgb * source.a) + (dest.rgb * (1 - source.a)) is conventional alpha blending
<Valathil> yes
<Valathil> i know
*** FUBAR-BDHR_ has joined #scp
<Swifty> blend(source, dest)  =  source.rgb + (dest.rgb * (1 - source.a)) is premultiplied or additive
<Valathil> i know
<Valathil> no wait
<Valathil> the second is wrong
<Valathil> that be weird
<Valathil> if you have completely black thing and 100% alpha it would result in black square
<Valathil> which is not additive
<Swifty> idk, read what Tom Forsyth has to say on it http://home.comcast.net/~tom_forsyth/blog.wiki.html#[[Premultiplied%20alpha]]
* MjnMixael is becoming a ghost
<Valathil> premultiplied is the better version of normal alpha blending
<Valathil> not additive
<Valathil> additive is still source.rgp + source.a + dest.rgb
<Valathil> source.rgp +* source.a + dest.rgb
<Valathil> fuck
<Valathil> you know what i mean
<Valathil> now let me get back to fixing the collision bug instead of veryfing that we both know what were talking about
<Swifty> which collision bug?
<Swifty> the one with weapons vs rotating subobjs?
*** GhostOfMjn has joined #scp
*** -NickServ- [email protected] has just authenticated as you (MjnMixael)
<Valathil> 2693
<Swifty> oh, that's something else then
<GhostOfMjn> Swifty, have you had a chance to look into the weapon collision issues?
<Swifty> no
<Swifty> i don't really know where to start
<Swifty> i suspect it's something to do with the sort and sweep stuff
<GhostOfMjn> fubar discovered it seems to be mostly dealing with rotating subsystems
<Swifty> have you guys verified that the collisions work again once you set those subsystems to not rotate?
<Valathil> it might interact with this bug now that i hear rotating
<Valathil> no thats just ship to ship
<Valathil> never mind me
*** sigtau|mac has quit IRC: Quit: *closes macbook lid*
<Valathil> interesting
<Valathil> there are two version of collision checks in ship_ship_check_collision both wrongly detect a collision
*** chief1983 has joined #scp
*** ChanServ sets mode +o chief1983
<chief1983> in bug 1616, is there not a chance that behavior was relied on by someone?
<Valathil> haha i think i know why the $no_collisions isnt working
<chief1983> I mean, maybe someone did a same-model ship class change and expected the texture replacement not to carry over
<Valathil> we dont actually check the light ships subsystems do we only the target of the collision
<Valathil> thats why the player can fly through the fenris but the fenris bumps on the ganymede
<Valathil> this comment is also a gold nugget "// should be no ships that can rotate this fast"
<Valathil> lets hope
<The_E> chief1983: That is such a highly specific case that I am not going to bother checking against it
<The_E> BEsides, the typical use case referred to here is much, much more elegantly handled by team colors
*** einstine909 has quit IRC: Remote host closed the connection
<Valathil> did i ever mention the collision code i an ugly hacked up piece of shit?
<The_E> GhostOfMjn: Have you tried reproducing 2605?
<GhostOfMjn> no
<GhostOfMjn> i shall though
<The_E> Awesome
<Valathil> is nobody talking to me?
<The_E> My personal working theory is that the person who reported it did not actually check whether the weapon he put onto the turret is actually one the AI would fire at a capital ship
<GhostOfMjn> yeah, that's what it sounds like to me
*** Valathil has quit IRC: Quit: Verlassend
<GhostOfMjn> and there's the smart spawn flag now too
<GhostOfMjn> but standby whilst I test
<GhostOfMjn> in theory Spawn + Capital+ should do the trick to just about any weapon
<GhostOfMjn> yeah, I've an orion firing Infyrno's at a Typhon
<The_E> By simply adding capital+?
<GhostOfMjn> yeah
<The_E> Right
<The_E> So closing that bug as working as intended would be justified
<GhostOfMjn> er, well I removed remote detonate, but yet
<GhostOfMjn> yes*
<chief1983> did Valathil just quit because he was being ignored?
<GhostOfMjn> dunno
<chief1983> or did he interpret your comment before he quit as directed at him, incorrectly
<The_E> Closing rapidly on only 150 open issues
<chief1983> awesome
<chief1983> You guys are killing it, I just want to say.
<The_E> A lot of it is due to mantis housekeeping, I should add
<GhostOfMjn> can you look at 1153?
<chief1983> Still
<chief1983> clean mantis means it's easier to find relevant bugs
<GhostOfMjn> indeed
<chief1983> and it's still time and effort to clean up
<chief1983> Trust me, I know all about that shit.
<chief1983> We had a bug queue at work the other day over 120 issues long
<chief1983> in a week we had whittled it down into the 30s, and then nearly less than 20 before it ballooned again :(
<chief1983> But it's a fight just to keep on top of what's actually an issue or not.
<GhostOfMjn> after 1153, 2713, 2165, and 2325 need coder attention.
<The_E> Checking 1153
<The_E> 1153 is closed