MF FPP crashconvo

tonio - japanman04/30/2020
hi, I'm new, i'd like to report a bug when i loaded the mobilefactory mod
https://prnt.sc/s8pwco
Lightshot
Screenshot

18.21 factorio

Dexy04/30/2020
This mean that you have a mod who blindly add a upgrade to all mining drills

tonio - japanman04/30/2020
hmm okay, any way i can find out the culprit?
oh i think it's built in beacons

Dexy04/30/2020
Can be fixed
tonio - japanman04/30/2020
Ok, it is easy? Like changing some lines?

Dexy04/30/2020
Maybe @Honktown will do that
I can’t do that with my phone

☆Spark04/30/2020
9 chances out of 10 that's factorio plus plus

Honktown04/30/2020
There is no next_upgrade for the OreCleaner :angry:
Someone applied it to all mining drills
Because they're a jackass
Just got up >_>

Dexy04/30/2020
In fact, set the next upgrade to nil will fix the issue
Inside the ore cleaner entity declaration

Honktown04/30/2020
It should be nil

Dexy04/30/2020
I think no
Ore cleaner extend data from electric mining drill
And If a mod attempt to access the fast replace group
Boum, error

Honktown04/30/2020
fast_replaceable_group is a string
next_upgrade is nil
Because there is no next upgrade for mining drills
In vanilla

Dexy04/30/2020
But what if a mod add one
And was loaded before MF

Honktown04/30/2020
If he finds which one it'd be easier to deal with

@tonio - japanman
More information friend
factorio-current.log

Dexy04/30/2020
Just set the next upgrade to nil, this will fix that

Honktown04/30/2020
It is nil in Mobile Factory

Dexy04/30/2020
Sure ?

Honktown04/30/2020
Absolutely
OreCleaner starts as deepcopy of electric-mining-drill

Dexy04/30/2020
And?

Honktown04/30/2020
EMD doesn't have one!
There is no upgrade for it

Dexy04/30/2020
But what if a mod add one
@Dexy

Honktown04/30/2020
1) if something is upgradeable to another entity, it needs a group
2) if it is not the exact same size, that is an error :wink:
OreCleaner is bigger than normal drills

Dexy04/30/2020
But what if a mod add multiple tier of mining drills
(Hello Factorio ++)

Honktown04/30/2020
They are forcing their definition on a mis-matched entity

Dexy04/30/2020
Factorio check the group before checking the size

Honktown04/30/2020
Because they are Doing It Wrong (TM)

Dexy04/30/2020
This is why you see the group error

Honktown04/30/2020
I can add an unused fast_replaceable_group, and hope it works
Hope F++ ignores entities that already have one

Dexy04/30/2020
Or set the next upgrade to nil

Honktown04/30/2020
Dexy
it is nil
I could add F++ as a dependency

Dexy04/30/2020
https://prnt.sc/s8pwco
@tonio - japanman
Lightshot
Screenshot

Error say no

Honktown04/30/2020
      name = "electric-mining-drill",
      open_sound = 0,

Dexy04/30/2020
Pretty sure the next upgrade is not nil

Honktown04/30/2020
-- Entity --
ocE = table.deepcopy(data.raw["mining-drill"]["electric-mining-drill"])
There is no next_upgrade in our definition
Someone else is fucking it over

Dexy04/30/2020
Explanation:
Next upgrade is nil,
F++ mod loading
F++ set emd next upgrade to something
MF loading
Next upgrade is not nil
Crash

Honktown04/30/2020
Ahh that's what you mean
That we're copying an already-applied next_upgrade from the EMD

Dexy04/30/2020
Yep
:thumbsup: you understood
Then, set next upgrade to nil will fix the issue

Honktown04/30/2020
Hopefully. Unless F++ is blindly applying it
I was too quick to judgement
Not like the author is here anyway >_>

Dexy04/30/2020
Not sure that is caused by F++
It’s was an exemple

Honktown04/30/2020
It may or may not be
EMD has no next_upgrade
So they could be a doing a pairs and adding to anything with nil
A better fix would require more time, but I feel I should go through Erya logistics and set groups and set next_upgrades to good values
(they also do deepcopies)

Dexy04/30/2020
You can also override the deepcopy fonction and add a next upgrade to nil

Honktown04/30/2020
I'm starting with that
Belts should fast-replace belts
The Erya Mining Drill could be an issue. I don't know if I should nil the fast_replace_able group and upgrade or not

Dexy04/30/2020
The size can be an issue

Honktown04/30/2020
I will nil the upgrade, or we will literally get the same error lol
Not the same one, but the wrong size error
upgrade->group aand upgrade->group->size
I'm setting all the erya items to have no next upgrades... I already set the Fluid Extractor

Dexy04/30/2020
Yeah, f**k next_upgrade