PVS-StudioWarnings

PVS-Studio warning V519 for MTASA

Nov 19th, 2014
146
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.78 KB | None | 0 0
  1. class CChatEchoPacket : public CPacket
  2. {
  3.   ....
  4.   inline void SetColor( unsigned char ucRed,
  5.                         unsigned char ucGreen,
  6.                         unsigned char ucBlue )
  7.   { m_ucRed = ucRed; m_ucGreen = ucGreen; m_ucRed = ucRed; };
  8.   ....
  9. }
  10.  
  11. Most likely this is what should be written here: { m_ucRed = ucRed; m_ucGreen = ucGreen; m_ucBlue = ucBlue; };
  12.  
  13.  
  14. This suspicious code was found in MTASA project by PVS-Studio static code analyzer.
  15. Warning message is:
  16. V519 The 'm_ucRed' variable is assigned values twice successively. Perhaps this is a mistake. Check lines: 47, 47. cchatechopacket.h 47
  17.  
  18. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment