Hi Nik,

About ➜ https://github.com/henrypp/chromium/blob/master/hevc_support_new.md

Because compilations errors burn my old CPU and waste time for nothing in result, I would like to clarify some points with you before trying some compilation with codecs



████████████ Question 1 ████████████

When you said :

In the file:
    src/third_party/ffmpeg/ffmpeg_generated.gni
append to your condition:



        ffmpeg_c_sources += [
                "libavcodec/X.c",
                "… … blah blah … …",
                "libavformat/Y.c",
        ]
        ffmpeg_yasm_sources += [
                "libavcodec/x86/Z.asm",
                "… … blah blah … …",
                "libavcodec/x86/A.asm",
        ]



That mean to compile for a x64 windows platform I just have to add at the end of the file :



        if (is_win) {
            ffmpeg_c_sources += [
                    "libavcodec/X.c",
                    "… … blah blah … …",
                    "libavformat/Y.c",
            ]
            ffmpeg_yasm_sources += [
                    "libavcodec/x86/Z.asm",
                    "… … blah blah … …",
                    "libavcodec/x86/A.asm",
            ]
        }



████████████ Question 2 ████████████

When you said :

In the file:
    src/third_party/ffmpeg/chromium/config/YOUR_BRAND/win/YOUR_ARCH/config.asm
    src/third_party/ffmpeg/chromium/config/YOUR_BRAND/win/YOUR_ARCH/config.h

A/
For Chromium compilation is YOUR_BRAND always « Chromium » ?
Or is it « Chrome » if we use GN Arguments (gn args folder) « is_official_build = true » ?

B/
Because I compile using Visual Studio on a x64 Windows platform:
Do I must use the folder « win-msvc » or stick with « win » ? Or maybe both ?



████████████ Question 3 ████████████

When you said :

In the file:
    src/third_party/ffmpeg/chromium/config/YOUR_BRAND/win/YOUR_ARCH/config.asm
    src/third_party/ffmpeg/chromium/config/YOUR_BRAND/win/YOUR_ARCH/config.h

replace some parameters to:
    #define CONFIG_HEVC_DECODER 1
    #define … … …

Can I both replace in « ia32 » and « x64 » so the codecs will both operate on x64 ans x86 Windows machine ?