PVS-StudioWarnings

PVS-Studio warning V524 for Nmap

Nov 20th, 2014
174
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.74 KB | None | 0 0
  1. class NpingTimer {
  2.   ...
  3.   int start();
  4.   int stop();
  5.   ...
  6. };
  7.  
  8. int NpingStats::startRuntime(){
  9.   this->run_timer.start();
  10.   return OP_SUCCESS;
  11. }
  12.  
  13. int NpingStats::stopRuntime(){
  14.   this->run_timer.start();
  15.   return OP_SUCCESS;
  16. }
  17.  
  18. Most likely this is what should be written in stopRuntime: this->run_timer.stop();
  19.  
  20. This suspicious code was found in Nmap project by PVS-Studio static code analyzer.
  21. Warning message is:
  22. V524 It is odd that the body of 'stopRuntime' function is fully equivalent to the body of 'startRuntime' function (stats.cc, line 274). nping stats.cc 280
  23.  
  24. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment