Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- class NpingTimer {
- ...
- int start();
- int stop();
- ...
- };
- int NpingStats::startRuntime(){
- this->run_timer.start();
- return OP_SUCCESS;
- }
- int NpingStats::stopRuntime(){
- this->run_timer.start();
- return OP_SUCCESS;
- }
- Most likely this is what should be written in stopRuntime: this->run_timer.stop();
- This suspicious code was found in Nmap project by PVS-Studio static code analyzer.
- Warning message is:
- V524 It is odd that the body of 'stopRuntime' function is fully equivalent to the body of 'startRuntime' function (stats.cc, line 274). nping stats.cc 280
- PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment