PVS-StudioWarnings

PVS-Studio warning V547 for shp2xml

Nov 13th, 2014
174
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.53 KB | None | 0 0
  1. char *chkXml(char *buf) {
  2.  for (char *s = buf; *s; s++)
  3.    if (*s == '&') *s = '/';
  4.    ....
  5.    else if (*s > 127) *s = '~';
  6.  return buf;
  7. }
  8.  
  9. This suspicious code was found in shp2xml project by PVS-Studio static code analyzer.
  10. Warning message is:
  11. V547 Expression '* s > 127' is always false. The value range of signed char type: [-128, 127]. Shp2Xml shp2xml.cpp 18
  12.  
  13. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment