PVS-StudioWarnings

PVS-Studio warning V547 for TPP

Nov 17th, 2014
186
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.63 KB | None | 0 0
  1. int Dta2mzXML::extractScanNum(const string& dtaFileName)
  2. {
  3.   ...
  4.   std::string::size_type pos = dtaFileName.rfind("/");
  5.  
  6.   if (pos < 0)  {
  7.     pos = dtaFileName.rfind("\\");
  8.   }
  9.   ...
  10. }
  11.  
  12. This is what should have been written here: (pos == string::npos).
  13.  
  14.  
  15. This suspicious code was found in TPP project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V547 Expression 'pos < 0' is always false. Unsigned type value is never < 0. dta2mzXML dta2mzxml.cpp 622
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment