PVS-StudioWarnings

PVS-Studio warning V501 for KDE4

Nov 20th, 2014
158
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 1.00 KB | None | 0 0
  1. void IconView::dropEvent(QGraphicsSceneDragDropEvent *event)
  2. {
  3.   ....
  4.   if (mimeData->hasFormat(QLatin1String(
  5.        "application/x-kde-ark-dndextract-service")) &&      //<==
  6.       mimeData->hasFormat(QLatin1String(
  7.        "application/x-kde-ark-dndextract-service")))        //<==
  8.   {
  9.     const QString remoteDBusClient = mimeData->data(
  10.       QLatin1String("application/x-kde-ark-dndextract-service"));
  11.     const QString remoteDBusPath = mimeData->data(
  12.       QLatin1String("application/x-kde-ark-dndextract-path"));
  13.     ....
  14.   }
  15.   ....
  16. }
  17.  
  18. This suspicious code was found in KDE4 project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V501 There are identical sub-expressions 'mimeData->hasFormat(QLatin1String("application/x-kde-ark-dndextract-service"))' to the left and to the right of the '&&' operator. iconview.cpp 2357
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment