PVS-StudioWarnings

PVS-Studio warning V654 for VirtualBox

Nov 12th, 2014
194
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.75 KB | None | 0 0
  1. DECLHIDDEN(int) supHardNtLdrCacheOpen(const char *pszName, ....)
  2. {
  3.   ....
  4.   uint32_t i = 0;
  5.   while (i < RT_ELEMENTS(g_apszSupNtVpAllowedDlls))
  6.     if (!strcmp(pszName, g_apszSupNtVpAllowedDlls[i]))
  7.       break;
  8.   ....
  9. }
  10.  
  11. What is dangerous about this loop is that the counter value doesn't change, so if the very first array item doesn't coincide with 'pszName', we'll get an infinite loop.
  12.  
  13. This suspicious code was found in VirtualBox project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V654 The condition of loop is always true. suphardenedverifyprocess-win.cpp 1732
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment