PVS-StudioWarnings

PVS-Studio warning V530 for QuantLib

Nov 19th, 2014
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.77 KB | None | 0 0
  1. void CommodityCurve::setPrices(std::map<Date, Real>& prices) {
  2.   QL_REQUIRE(prices.size()>1, "too few prices");
  3.  
  4.   dates_.empty();
  5.   data_.empty();
  6.  
  7.   for (std::map<Date, Real>::const_iterator i = prices.begin();
  8.        i != prices.end(); i++)
  9.   {
  10.     dates_.push_back(i->first);
  11.     data_.push_back(i->second);
  12.   }
  13.   ....
  14. }
  15.  
  16. This is what should have been written here: dates_.clear(); data_.clear();
  17.  
  18. This suspicious code was found in QuantLib project by PVS-Studio static code analyzer.
  19. Warning message is:
  20. V530 The return value of function 'empty' is required to be utilized. commoditycurve.cpp 70
  21.  
  22. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment