Advertisement
Guest User

Untitled

a guest
Oct 19th, 2017
86
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
Diff 4.24 KB | None | 0 0
  1. diff --git a/WebDriverTests/imported/w3c/webdriver/tests/conftest.py b/WebDriverTests/imported/w3c/webdriver/tests/conftest.py
  2. index e1491a68026..b7b8b83c9a3 100644
  3. --- a/WebDriverTests/imported/w3c/webdriver/tests/conftest.py
  4. +++ b/WebDriverTests/imported/w3c/webdriver/tests/conftest.py
  5. @@ -1,8 +1,9 @@
  6.  import pytest
  7.  from tests.support.fixtures import (
  8. -    configuration, create_dialog, create_frame, create_window, http,
  9. -    new_session, server_config, session, url)
  10. +    add_browser_capabilites, configuration, create_dialog, create_frame,
  11. +    create_window, http, new_session, server_config, session, url)
  12.  
  13. +pytest.fixture()(add_browser_capabilites)
  14.  pytest.fixture(scope="session")(configuration)
  15.  pytest.fixture()(create_dialog)
  16.  pytest.fixture()(create_frame)
  17. diff --git a/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py b/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py
  18. index 0128c45d4fe..23350488ddc 100644
  19. --- a/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py
  20. +++ b/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_alwaysMatch.py
  21. @@ -8,6 +8,6 @@ from support.create import valid_data
  22.  
  23.  
  24.  @pytest.mark.parametrize("key,value", flatten(product(*item) for item in valid_data))
  25. -def test_valid(new_session, key, value):
  26. -    resp = new_session({"capabilities": {"alwaysMatch": {key: value}}})
  27. +def test_valid(new_session, add_browser_capabilites, key, value):
  28. +    resp = new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({key: value})}})
  29.  
  30. diff --git a/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py b/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py
  31. index f0540309108..aab9af06ac5 100644
  32. --- a/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py
  33. +++ b/WebDriverTests/imported/w3c/webdriver/tests/sessions/new_session/create_firstMatch.py
  34. @@ -8,5 +8,5 @@ from support.create import valid_data
  35.  
  36.  
  37.  @pytest.mark.parametrize("key,value", flatten(product(*item) for item in valid_data))
  38. -def test_valid(new_session, key, value):
  39. -    resp = new_session({"capabilities": {"firstMatch": [{key: value}]}})
  40. +def test_valid(new_session, add_browser_capabilites, key, value):
  41. +    resp = new_session({"capabilities": {"alwaysMatch": add_browser_capabilites({}), "firstMatch": [{key: value}]}})
  42. diff --git a/WebDriverTests/imported/w3c/webdriver/tests/support/fixtures.py b/WebDriverTests/imported/w3c/webdriver/tests/support/fixtures.py
  43. index d93f862578a..73d6abeeb4a 100644
  44. --- a/WebDriverTests/imported/w3c/webdriver/tests/support/fixtures.py
  45. +++ b/WebDriverTests/imported/w3c/webdriver/tests/support/fixtures.py
  46. @@ -8,7 +8,7 @@ import mozlog
  47.  
  48.  from tests.support.asserts import assert_error
  49.  from tests.support.http_request import HTTPRequest
  50. -from tests.support import merge_dictionaries
  51. +from tests.support import merge_dictionaries, overwrite_dictionary
  52.  
  53.  default_host = "http://127.0.0.1"
  54.  default_port = "4444"
  55. @@ -188,8 +188,6 @@ def new_session(configuration, request):
  56.          _session = webdriver.Session(configuration["host"],
  57.                                       configuration["port"],
  58.                                       capabilities=None)
  59. -        # TODO: merge in some capabilities from the confguration capabilities
  60. -        # since these might be needed to start the browser
  61.          value = _session.send_command("POST", "session", body=body)
  62.          # Don't set the global session until we are sure this succeeded
  63.          _current_session = _session
  64. @@ -203,6 +201,16 @@ def new_session(configuration, request):
  65.      return create_session
  66.  
  67.  
  68. +def add_browser_capabilites(configuration):
  69. +    def update_capabilities(capabilities):
  70. +        # Make sure there aren't keys in common.
  71. +        assert not set(configuration["capabilities"]).intersection(set(capabilities))
  72. +        result = dict(configuration["capabilities"])
  73. +        result.update(capabilities)
  74. +        return result
  75. +    return update_capabilities
  76. +
  77. +
  78.  def url(server_config):
  79.      def inner(path, protocol="http", query="", fragment=""):
  80.          port = server_config["ports"][protocol][0]
Advertisement
Add Comment
Please, Sign In to add comment
Advertisement