PVS-StudioWarnings

PVS-Studio warning V636 for Geant4

Nov 13th, 2014
175
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.73 KB | None | 0 0
  1. G4double G4XAqmTotal::CrossSection(
  2.   const G4KineticTrack& trk1, const G4KineticTrack& trk2) const
  3. {
  4.   ....
  5.   G4int sTrk1 = ....;
  6.   G4int qTrk1 = ....;
  7.  
  8.   G4double sRatio1 = 0.;
  9.   if (qTrk1 != 0) sRatio1 = sTrk1 / qTrk1;
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in Geant4 project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V636 The 'sTrk1 / qTrk1' expression was implicitly casted from 'int' type to 'double' type. Consider utilizing an explicit type cast to avoid the loss of a fractional part. An example: double A = (double)(X) / Y;. g4xaqmtotal.cc 103
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment