PVS-StudioWarnings

PVS-Studio warning V562 for blender

Nov 13th, 2014
178
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.65 KB | None | 0 0
  1. #define MAX2(x,y) ( (x)>(y) ? (x) : (y) )
  2.  
  3. static Scene *preview_prepare_scene(....)
  4. {
  5.   ...
  6.   int actcol = MAX2(base->object->actcol > 0, 1) - 1;
  7.   ...
  8. }
  9.  
  10. Most likely this is what should be written here: int actcol = MAX2(base->object->actcol, 1) - 1;
  11.  
  12. This suspicious code was found in blender project by PVS-Studio static code analyzer.
  13. Warning message is:
  14. V562 It's odd to compare 0 or 1 with a value of 1: (base->object->actcol > 0) > (1). bf_editor_render render_preview.c 361
  15.  
  16. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment