Not a member of Pastebin yet?
Sign Up,
it unlocks many cool features!
- Our man page changes for this quarter are at:
- https://gist.github.com/alanc/412842f5e4cc6b0f67acfb92d16c7b00
- Along with a cleanup pass of extra space inserted by our XML->nroff conversions,
- my big man page project for the quarter was a cleanup pass across the
- section 3C man pages. Changes from those included:
- - Formatting, spelling, grammar, wording, and typo fixes across many pages
- - Remove less useful / add more useful "See Also" entries in several pages
- - Add History sections to many pages
- - Add Attributes tables in a few pages
- - Standardize on <> being included in the bold text for header references
- (by standardizing on <filename class="headerfile"> markup in the XML)
- - Note that thread-specific data returned by some functions will
- be unallocated when the thread is gone.
- clock(3C):
- - Update usage note to reflect that clock_t is a typedef long, so only
- overflows quickly in 32-bit processes, not 64-bit.
- clock_settime(3C):
- - Add missing CLOCK_MONOTONIC definition (specified by POSIX).
- ctime(3C):
- - Stop claiming the sysadmin has to set DST switching dates every year
- since we now rely on the timezone database for that.
- dup3(3C):
- - Reflect clarification from https://austingroupbugs.net/view.php?id=1577
- getopt(3C);
- - Show 21st century standards first, ahead of 20th century standards.
- getrusage(3C):
- - Stop insulting raf's memory and correct the claim that it is impossible
- to get resource usage information of processes that have not yet
- terminated when /proc is right there.
- - Replace sar(8) with sstore(1).
- getsubopt(3C):
- - Restore introductory text from SunOS 4 man page that explains what
- suboptions are.
- getvfsent(3C):
- - Add USAGE section suggesting you probably want getmntent(3C) instead.
- posix_fallocate(3C):
- - Add note to USAGE section warning that it does not work on ZFS.
- posix_spawnattr_destroy(3C):
- - Correct claim that Solaris has no attributes not defined by POSIX,
- since while that was true for Solaris 10, it's not been true since 11.0.
- select(3C):
- - Correct info on default open file limit.
- setjmp(3C):
- - Clarify that these functions operate on a single thread.
- shutdown(3C):
- - Clarify that shutdown() doesn't close the socket, the caller has to.
- Fixes I see that apply to your pages as well include:
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man2/msgrcv.2#L252
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man2/msgsnd.2#L231
- - Extra space between "\fB" and "\fB"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3/Intro.3#L959
- - NULL is defined in <stddef.h>, not <stdio.h>
- - many more definitions are provided in Intro(2)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3/Intro.3#L1106
- - missing <> around math.h
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/abort.3c#L21
- - "is being caught" should be "is caught", per
- https://austingroupbugs.net/view.php?id=906
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/abort.3c#L46
- - if coreadm is configured to capture global core dumps, or core dumps under
- a different path, a core dump may be produced even if the current directory
- is not writable
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/attropen.3c#L17
- - the opening "/*" and closing "*/" are mismatched levels of boldness
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/clock.3c#L37-L38
- - the 36 minute wraparound claim is only true in 32-bit code (but we still
- added a recommendation to use clock_gettime(3C) with CLOCK_PROCESS_CPUTIME_ID
- instead of this function)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/cond_init.3c#L430
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getopt.3c#L421
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3scf/scf_transaction_create.3scf#L551
- - extra space before comma
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ctime.3c#L210-L213
- - libc also knows about the 2007 changes to US daylight savings time, in which
- daylight savings time now starts in March, not on the first Sunday in April.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ctime.3c#L394-L395
- - sysadmins are no longer required to do this as long as tzdata is up to date
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/dlinfo.3c#L280
- - "one of more" should be "one or more"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/door_create.3c
- - missing a mention of the new & improved door_xcreate(3C) alternative API
- (for which you seem to be missing the man page entirely - see
- https://illumos.org/opensolaris/ARChive/PSARC/2009/554/index.html )
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/door_getparam.3c#L171
- - missing "the" before "supported range"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/door_getparam.3c#L182
- - missing "ch" and indentation for "char" variable type
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/dup2.3c#L101
- - this can also happen for dup3() not just dup2()
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/freopen.3c#L53
- - the arguments should have the "restrict" qualifier to match the header
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ftell.3c#L82
- - "sets" should be "set", since the subject is "they"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getgrnam.3c#L240-L241
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getlogin.3c#L187-L188
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getpwnam.3c#L268-L269
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getspnam.3c#L172-L173
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ptsname.3c#L125-L127
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ttyname.3c#L170-L171
- - use of thread-specific data must also not be done after the thread which
- made the call has ended (see https://austingroupbugs.net/view.php?id=656
- for these & more)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/gethrtime.3c#L38
- - comma should not be inside the bold markup
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/gethrtime.3c
- - does not mention that clock_gettime(3C) is the standard/portable API for this
- functionality now
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getopt.3c#L93
- - Intro(1) should be marked up as a man page reference
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getopt.3c#L455
- - This sentence has very twisted up grammar.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getrusage.3c#L331-L332
- - This limitation is only true for this API - the use of proc(5) allows
- gathering information about running processes.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getspnam.3c#L121
- - The "." should not be inside the italic markup.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getspnam.3c#L160
- - Missing space before "and"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getspnam.3c#L214-L218
- - This warning seems unnecessary now and can be replaced by a Stability level
- in the Attributes table. (They've been there since Solaris 2.3.)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getsubopt.3c
- - it helps to explain that "suboption arguments" are comma separated arguments,
- like the mount command uses for the -o option.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getsubopt.3c#L138-L140
- - K&R C is so pre-1989 (and the rest of the code could use some cstyle help)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L165
- - "." or ";" pick one, but don't put both together
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L173
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L178
- - missing "the" after "for"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L188
- - missing ")" to match "(" two lines above it.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L204
- - unnecessary "," after "wait(3C)"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L242
- - extra space between "getutxid" and "()"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getutxent.3c#L312
- - missing "utmpd(8)" in See Also list
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/getvfsent.3c#L62
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ndbm.3c#L107
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ndbm.3c#L107
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ndbm.3c#L331
- - "file" should be italic (argument name) not bold (command/function name)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/glob.3c
- - the markup including "->" in the italic section with "pglob" in many places
- in this page looks funny
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/isastream.3c#L22
- - "return" should be "returned"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/madvise.3c
- - no mentions or even see also for madv.so.1(1), pmadvise(1), posix_madvise(3C)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/mutex_init.3c#L582-L583
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/mutex_init.3c#L649-L650
- - it's not necessary to set i=0 in both lines (and this code could also use
- some cstyle help, and a return type for main() now that compilers reject
- implicit int declarations)
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ndbm.3c#L193
- - extra space before "."
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ndbm.3c#L311-L313
- - Copies can be made without filling the holes by using cpio, pax, or GNU cp now.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/popen.3c#L178
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/setjmp.3c#L166
- - main() should have a return type and argument information to make ANSI C
- compilers happy
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/port_get.3c#L94
- - "errno" should be bold
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/posix_fallocate.3c
- - doesn't warn that this function doesn't actually allocate space on ZFS
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/posix_spawnattr_destroy.3c#L85
- - at least for us, it's no longer true that no non-standard attributes are
- provided by the OS
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/posix_spawnattr_getflags.3c#L122-L123
- - missing markup for parameter/variable names
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/realpath.3c
- - does not mention that if you pass NULL for resolved_name, you are responsible
- for freeing the newly allocated buffer (yours doesn't even seem to mention
- this is allowed, except that canonicalize_file_path says it does that,
- even though ERRORS says it will return EINVAL for that)
- - does not mention that if you pass a buffer for resolved_name, it must be
- at least PATH_MAX bytes.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/setjmp.3c#L84-L88
- - sigsetjmp() saves registers/stack/signal mask for just the calling thread,
- not every thread in the process
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/setjmp.3c#L260-L262
- - Warnings missing note from
- https://pubs.opengroup.org/onlinepubs/9699919799/functions/longjmp.html
- that calling *longjmp from a different thread than *setjmp is undefined.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3socket/shutdown.3socket
- - Does not say that the caller is responsible for calling close() after
- shutdown() completes.
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/signal.3c#L108
- - missing "of" after "execution"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/ungetc.3c#L24-L25
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9e/devmap.9e#L128-L129
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9e/ioctl.9e#L172-L174
- - newline after "(" causes extra space in output
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wait.3c#L62-L65
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wait3.3c#L24-L25
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/waitpid.3c#L62-L65
- - missing case for immediate return (no waiting) on error - see
- https://austingroupbugs.net/view.php?id=690
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wait.3c#L94
- - missing space between "7" and "bits"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wait3.3c#L108
- - "return" should be "returns"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wait3.3c#L191
- - missing space between "wait3()\fR" and "and"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/waitpid.3c#L213
- - the "." should not be inside the italic markup
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wordexp.3c
- - the markup including "->" in the italic section with "exp" in many places
- in this page looks funny
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3c/wordexp.3c#L367
- - "executing shell command" should be either "a shell command" or
- "shell commands"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_addwchstr.3curses#L51
- - "chtype" should be bold, "wchstr" should be italic
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man2/msgsnd.2#L278
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_getch.3curses#L109
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_getwch.3curses#L110
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_touch.3curses#L61
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/menu_opts.3curses#L118
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/getch.3xcurses#L149
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/keypad.3xcurses#L133
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/keypad.3xcurses#L135
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/keypad.3xcurses#L141
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/keypad.3xcurses#L180
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/vwscanw.3xcurses#L30
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4d/qlc.4d#L124
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/STRUCT_DECL.9f#L101
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_devstate.9f#L50
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_devstate.9f#L59
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_devstate.9f#L70
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_devstate.9f#L80
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_pid.9f#L31
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_pid.9f#L39
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_time.9f#L33
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/ddi_get_time.9f#L44
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/usb_pipe_isoc_xfer.9f#L164
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/usb_pipe_isoc_xfer.9f#L297
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9s/scsi_asc_key_strings.9s#L15
- - Extra space at start of line
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_getwch.3curses#L49-L50
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3curses/curs_inopts.3curses#L165
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/get_wch.3xcurses#L67
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9e/devmap.9e#L130
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/getq.9f#L37
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man9f/mt-streams.9f#L31
- - Extra spaces after "(" and/or before ")"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man3xcurses/immedok.3xcurses#L29
- - Extra space before "()"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4d/ibcm.4d
- - Extra space before "Consolidation Private"
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4d/qlc.4d#L105
- https://github.com/illumos/illumos-gate/blob/master/usr/src/man/man4d/qlc.4d#L111
- - Extra spaces between words in titles
Advertisement
Add Comment
Please, Sign In to add comment