PVS-StudioWarnings

PVS-Studio warning V501 for samba

Nov 24th, 2014
177
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.66 KB | None | 0 0
  1. static bool samu_correct(struct samu *s1, struct samu *s2)
  2. {
  3.   ....
  4.   } else if (s1_len != s1_len) {
  5.     DEBUG(0, ("Password history not written correctly, "
  6.               "lengths differ, want %d, got %d\n",
  7.           s1_len, s2_len));
  8.     ret = False;
  9.   }
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in samba project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V501 There are identical sub-expressions to the left and to the right of the '!=' operator: s1_len != s1_len pdbtest.c 106
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment