Guest User

Player poll tg station

a guest
Aug 26th, 2024
107
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
text 2.92 KB | None | 0 0
  1. It really surprises me that even though it's an open source game, no development standard is used. From how features are implemented in the game codebase, all the way to how TGS.
  2.  
  3. # For the codebase
  4. Setting up a proper git flow is possible, you just need the maintainers to know how to police the codebase properly. Maybe you should read about this (or just search online "git flow"): https://www.gitkraken.com/learn/git/git-flow
  5.  
  6. "Oh but we would just be running the server on the dev branch"
  7. This is just making excuses when you're too lazy to do things properly.
  8. Do you need to test something with a lot of players? No problems, just switch the server TEMPORARILY on the dev branch.
  9. Just set up a standard for this and keep time frames strict for the temporary switch. For example, 1 week every month the server is switched on the dev branch and a development freeze is put in place.
  10. The features that got good feedback from the players of both mrp and lrp can be merged to master. The others, will be put aside for further development and will be tested again for the next dev freeze.
  11.  
  12. # TGS
  13. I know this is separate from the codebase but i will still use this oportunity to voice my concerns about TGS. I will be speaking about the 5.16 version of the docker container since that's the only latest release available on the docker hub. And no im not building the latest image myself, sorry.
  14.  
  15. ## Docker container
  16. Why is there a setup script inside the container?
  17. Please just give me a good reason why this is the case because i can't think of one.
  18.  
  19. A container is supposed to be built in a way that when the container starts, it is ready to be used.
  20. You should use docker compose variables and have the set up be done inside the web panel.
  21.  
  22. ## Logging and Vulnerability Analysis
  23. The error popups are either CWE hell or 1 liners that give no information and can't find any info about it on the 512 bus discord.
  24.  
  25. What do i mean by CWE hell?
  26. For example, in the login webpage you can see the TGS version and the web panel version in the tab name. If there is any known exploit, a threat actor can use this easily accessible information to attack a server. The less information they have, the better.
  27.  
  28. Also when you login with incorrect information, it
  29.  
  30. ## Upgrading
  31. Why is upgrading done inside the web panel??? To who ever that made this, i want to have a peaceful conversation inside a rage cage.
  32.  
  33. On a more serious note, just make people upgrade with docker images instead and have them use volumes to store persistent data.
  34. Do you want to update TGS when there's a new version automatically? Use a webhook connected to the TGS codebase (you can use portainer buisness edition to automatically do this (i know there is a way to get a free yearly renewable license))
  35.  
  36. # Final comments
  37. I know your way of implementing features has been done a certain (non standard) way but sometimes, you need to take a step back and re-evaluate what you're doing.
Advertisement
Add Comment
Please, Sign In to add comment