PVS-StudioWarnings

PVS-Studio warning V547 for ReactOS

Nov 18th, 2014
177
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.62 KB | None | 0 0
  1. typedef UINT_PTR SOCKET;
  2.  
  3. #define ADNS_SOCKET SOCKET
  4.  
  5. struct adns__state {
  6.   ...
  7.   ADNS_SOCKET udpsocket, tcpsocket;
  8.   ...
  9. };
  10.  
  11. void adns_finish(adns_state ads) {
  12.   ...
  13.   if (ads->tcpsocket >= 0) adns_socket_close(ads->tcpsocket);
  14.   ...
  15. }
  16.  
  17. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  18. Warning message is:
  19. V547 Expression 'ads->tcpsocket >= 0' is always true. Unsigned type value is always >= 0. adns setup.c 683
  20.  
  21. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment