PVS-StudioWarnings

PVS-Studio warning V519 for Crystalspace

Nov 18th, 2014
148
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.83 KB | None | 0 0
  1. csVector3 sampleDistanceReal;
  2.  
  3. void csSimpleSampler::CachePositions ()
  4. {
  5.   ...
  6.   // Compute distance between sample points
  7.   sampleDistanceReal = (resx == 1) ? 0 :
  8.     (maxCorner.x-minCorner.x)/(float)(resx-1);
  9.   sampleDistanceReal = (resz == 1) ? 0 :
  10.     (maxCorner.z-minCorner.z)/(float)(resz-1);
  11.   ...
  12. }
  13.  
  14. Most likely this is what should be written here: sampleDistanceReal.x = ...; sampleDistanceReal.z = ...;
  15.  
  16. This suspicious code was found in Crystalspace project by PVS-Studio static code analyzer.
  17. Warning message is:
  18. V519 The 'sampleDistanceReal' object is assigned values twice successively. Perhaps this is a mistake. plgsimpleformer simpleformer.cpp 642
  19.  
  20. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment