PVS-StudioWarnings

PVS-Studio warning V676 for Virtualdub

Nov 20th, 2014
192
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.66 KB | None | 0 0
  1. bool guiChooseColor(HWND hwnd, COLORREF& rgbOld) {
  2.   ....
  3.   if (ChooseColor(&cc)==TRUE) {;
  4.     rgbOld = cc.rgbResult;
  5.     return true;
  6.   }
  7.   ....
  8. }
  9.  
  10. If the user clicks the OK button of the dialog box, the return value is **nonzero**.
  11.  
  12.  
  13. This suspicious code was found in Virtualdub project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V676 It is incorrect to compare the variable of BOOL type with TRUE. Correct expression is: 'ChooseColorA(& cc) != FALSE'. VirtualDub gui.cpp 665
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment