PVS-StudioWarnings

PVS-Studio warning V575 for ReactOS

Nov 11th, 2014
151
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.71 KB | None | 0 0
  1. #define RtlFillMemory(Destination, Length, Fill) \
  2.   memset(Destination, Fill, Length)
  3.  
  4. #define IOPM_FULL_SIZE          8196
  5.  
  6. HalpRestoreIopm(VOID)
  7. {
  8.   ...
  9.   RtlFillMemory(HalpSavedIoMap, 0xFF, IOPM_FULL_SIZE);
  10.   ...
  11. }
  12.  
  13. Arguments are mixed up. This is what should have been written here: RtlFillMemory(HalpSavedIoMap, IOPM_FULL_SIZE, 0xFF);
  14.  
  15. This suspicious code was found in ReactOS project by PVS-Studio static code analyzer.
  16. Warning message is:
  17. V575 The 'memset' function processes value '8196'. Inspect the second argument. hal bios.c 427
  18.  
  19. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment