PVS-StudioWarnings

PVS-Studio warning V663 for OpenMW

Nov 20th, 2014
158
0
Never
Not a member of Pastebin yet? Sign Up, it unlocks many cool features!
C++ 0.67 KB | None | 0 0
  1. void Storage::loadDataFromStream(
  2.   ContainerType& container, std::istream& stream)
  3. {
  4.   std::string line;
  5.   while (!stream.eof())
  6.   {
  7.     std::getline( stream, line );
  8.     ....
  9.   }
  10.   ....
  11. }
  12.  
  13. This suspicious code was found in OpenMW project by PVS-Studio static code analyzer.
  14. Warning message is:
  15. V663 Infinite loop is possible. The 'cin.eof()' condition is insufficient to break from the loop. Consider adding the 'cin.fail()' function call to the conditional expression. components translation.cpp 45
  16.  
  17. PVS-Studio is a static analyzer for detecting bugs in the source code of applications written in C, C++, C++11, C++/CX. Site: http://www.viva64.com/en/pvs-studio/
Advertisement
Add Comment
Please, Sign In to add comment